Review Request: Fix regression of group shape size

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102633/#review6569
-----------------------------------------------------------


Have you checked whether this breaks Krita? I seem to remember we discussed this at least two times on #calligra and both times we arrived at another solution than reverting Adam's patches. See https://svn.reviewboard.kde.org/r/5253/, https://svn.reviewboard.kde.org/r/5231/#review7597 and https://svn.reviewboard.kde.org/r/5231/. 

So please check for regressions in bug https://bugs.kde.org/show_bug.cgi?id=227512 

- Boudewijn


On Sept. 16, 2011, 11:53 a.m., Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102633/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 11:53 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> There was a regression introduced that made the group shape always returning a zero size. This broke the filter effect on group shape feature.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeGroup.cpp aa8c1f3 
>   libs/flake/SimpleShapeContainerModel.h deee6a9 
>   libs/flake/tests/TestShapeContainer.cpp 5f51c9c 
> 
> Diff: http://git.reviewboard.kde.org/r/102633/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110916/4e0b3af7/attachment.htm>