Review Request: Fix regression of group shape size
Casper Boemann
cbr at boemann.dk
Fri Sep 16 14:31:47 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102633/#review6570
-----------------------------------------------------------
I'd support this change. Even if shapegroup is just a logical group it still should have the size of the shapes it groups.
But naturally we should avoid regressions.
- Casper
On Sept. 16, 2011, 11:53 a.m., Jan Hambrecht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102633/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2011, 11:53 a.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> There was a regression introduced that made the group shape always returning a zero size. This broke the filter effect on group shape feature.
>
>
> Diffs
> -----
>
> libs/flake/KoShapeGroup.cpp aa8c1f3
> libs/flake/SimpleShapeContainerModel.h deee6a9
> libs/flake/tests/TestShapeContainer.cpp 5f51c9c
>
> Diff: http://git.reviewboard.kde.org/r/102633/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110916/bcfa1e45/attachment.htm>
More information about the calligra-devel
mailing list