<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102633/">http://git.reviewboard.kde.org/r/102633/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you checked whether this breaks Krita? I seem to remember we discussed this at least two times on #calligra and both times we arrived at another solution than reverting Adam's patches. See https://svn.reviewboard.kde.org/r/5253/, https://svn.reviewboard.kde.org/r/5231/#review7597 and https://svn.reviewboard.kde.org/r/5231/.
So please check for regressions in bug https://bugs.kde.org/show_bug.cgi?id=227512 </pre>
<br />
<p>- Boudewijn</p>
<br />
<p>On September 16th, 2011, 11:53 a.m., Jan Hambrecht wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jan Hambrecht.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2011, 11:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There was a regression introduced that made the group shape always returning a zero size. This broke the filter effect on group shape feature.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShapeGroup.cpp <span style="color: grey">(aa8c1f3)</span></li>
<li>libs/flake/SimpleShapeContainerModel.h <span style="color: grey">(deee6a9)</span></li>
<li>libs/flake/tests/TestShapeContainer.cpp <span style="color: grey">(5f51c9c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>