Review Request: Add PDF support to KOConverter

[Jarosław Staniek]

> On Oct. 12, 2011, 4:40 p.m., Thorsten Zachmann wrote:
> > tools/converter/koconverter.cpp, line 51
> > <http://git.reviewboard.kde.org/r/102837/diff/1/?file=38640#file38640line51>
> >
> >     There should be no space after( and before ). This is also true for the rest of the patch
> 
> Dan Leinir Turthra Jensen wrote:
>     Normally i would agree - however, the rest of the code in koconverter uses this format. i would like to change this particular set of whitespace errors in a separate patch, and for now simply avoid inconsistencies.

Not a problem. I'll tell you what I do in such cases.
1. Apply astyle-kdelibs *.h *.cpp *.cc [1], commit (without review)
2. Apply my actual patch and just then provide for review.

[1] astyle-kdelibs:
#!/bin/bash

# apply kdelibs coding style to all c, cpp and header files in and below the
# current directory 
# 
# the coding style is defined in
# http://techbase.kde.org/Policies/Kdelibs_Coding_Style 
# 
# requirements: installed astyle 

astyle --indent=spaces=4 --brackets=linux \
      --indent-labels --pad-oper --unpad-paren --pad-header \
      --keep-one-line-statements --convert-tabs \
      --indent-preprocessor --align-pointer=name \
      --lineend=linux $*


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102837/#review7269
-----------------------------------------------------------


On Oct. 12, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102837/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 2:21 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As subject indicates. Using the pdf printing functionality, add support for converting documents to pdf using koconverter.
> 
> Furthermore, though this patch does not include it (it pollutes the patch with too many extraneous lines), this also changes the application binary name from koconverter to calligraconverter. 
> 
> 
> Diffs
> -----
> 
>   tools/converter/CMakeLists.txt d3fee33 
>   tools/converter/koconverter.cpp abf2a58 
> 
> Diff: http://git.reviewboard.kde.org/r/102837/diff/diff
> 
> 
> Testing
> -------
> 
> Testing with various documents, all converting accurately to pdf format
> 
> 
> Thanks,
> 
> Dan Leinir Turthra Jensen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111012/0f1c2363/attachment.htm>