Review Request: Add PDF support to KOConverter

[Dan Leinir Turthra Jensen]

> On Oct. 12, 2011, 4:40 p.m., Thorsten Zachmann wrote:
> > tools/converter/koconverter.cpp, line 51
> > <http://git.reviewboard.kde.org/r/102837/diff/1/?file=38640#file38640line51>
> >
> >     There should be no space after( and before ). This is also true for the rest of the patch

Normally i would agree - however, the rest of the code in koconverter uses this format. i would like to change this particular set of whitespace errors in a separate patch, and for now simply avoid inconsistencies.


> On Oct. 12, 2011, 4:40 p.m., Thorsten Zachmann wrote:
> > tools/converter/CMakeLists.txt, line 14
> > <http://git.reviewboard.kde.org/r/102837/diff/1/?file=38639#file38639line14>
> >
> >     is linking to kopageapp needed? I don't see any function you call from it

Well spotted - this is a leftover from an earlier attempt. Done :)


> On Oct. 12, 2011, 4:40 p.m., Thorsten Zachmann wrote:
> > tools/converter/koconverter.cpp, line 62
> > <http://git.reviewboard.kde.org/r/102837/diff/1/?file=38640#file38640line62>
> >
> >     There should be a blank after (

Done


- Dan Leinir Turthra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102837/#review7269
-----------------------------------------------------------


On Oct. 12, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102837/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 2:21 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As subject indicates. Using the pdf printing functionality, add support for converting documents to pdf using koconverter.
> 
> Furthermore, though this patch does not include it (it pollutes the patch with too many extraneous lines), this also changes the application binary name from koconverter to calligraconverter. 
> 
> 
> Diffs
> -----
> 
>   tools/converter/CMakeLists.txt d3fee33 
>   tools/converter/koconverter.cpp abf2a58 
> 
> Diff: http://git.reviewboard.kde.org/r/102837/diff/diff
> 
> 
> Testing
> -------
> 
> Testing with various documents, all converting accurately to pdf format
> 
> 
> Thanks,
> 
> Dan Leinir Turthra Jensen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111012/433c5f3e/attachment.htm>