Review Request: Add PDF support to KOConverter
Sebastian Sauer
mail at dipe.org
Wed Oct 12 18:21:55 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102837/#review7272
-----------------------------------------------------------
tools/converter/koconverter.cpp
<http://git.reviewboard.kde.org/r/102837/#comment6354>
maybe don't silent fail and return KoFilter::OK in that case? So, something like
status = KoFilter::StupidError;
what would be inline with what we do at filters/words/html/import/htmlimport.cpp:60
- Sebastian Sauer
On Oct. 12, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102837/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2011, 2:21 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> As subject indicates. Using the pdf printing functionality, add support for converting documents to pdf using koconverter.
>
> Furthermore, though this patch does not include it (it pollutes the patch with too many extraneous lines), this also changes the application binary name from koconverter to calligraconverter.
>
>
> Diffs
> -----
>
> tools/converter/CMakeLists.txt d3fee33
> tools/converter/koconverter.cpp abf2a58
>
> Diff: http://git.reviewboard.kde.org/r/102837/diff/diff
>
>
> Testing
> -------
>
> Testing with various documents, all converting accurately to pdf format
>
>
> Thanks,
>
> Dan Leinir Turthra Jensen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111012/1620e465/attachment.htm>
More information about the calligra-devel
mailing list