Review Request: Add PDF support to KOConverter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102837/#review7269
-----------------------------------------------------------



tools/converter/CMakeLists.txt
<http://git.reviewboard.kde.org/r/102837/#comment6349>

    is linking to kopageapp needed? I don't see any function you call from it



tools/converter/koconverter.cpp
<http://git.reviewboard.kde.org/r/102837/#comment6347>

    There should be no space after( and before ). This is also true for the rest of the patch



tools/converter/koconverter.cpp
<http://git.reviewboard.kde.org/r/102837/#comment6348>

    There should be a blank after (


- Thorsten Zachmann


On Oct. 12, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102837/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 2:21 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As subject indicates. Using the pdf printing functionality, add support for converting documents to pdf using koconverter.
> 
> Furthermore, though this patch does not include it (it pollutes the patch with too many extraneous lines), this also changes the application binary name from koconverter to calligraconverter. 
> 
> 
> Diffs
> -----
> 
>   tools/converter/CMakeLists.txt d3fee33 
>   tools/converter/koconverter.cpp abf2a58 
> 
> Diff: http://git.reviewboard.kde.org/r/102837/diff/diff
> 
> 
> Testing
> -------
> 
> Testing with various documents, all converting accurately to pdf format
> 
> 
> Thanks,
> 
> Dan Leinir Turthra Jensen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111012/0ab30e3b/attachment.htm>