Review Request: KoUnavailShape should show background fill

[Inge Wallin]

> On June 6, 2011, 1:29 p.m., Thorsten Zachmann wrote:
> > Would it be possible to see a document showing the problem? 
> > 
> > Also I think if the frame is empty it might be a bad idea for the unavail shape to pick it up or to display something. However you fix seams to do something else and is nowhere checking if there is content or not.
> >
> 
> Matus Hanzes wrote:
>     http://valdyas.org/~lukast/a.odt

Regarding the problem with empty frames: I think the unavail shape should pick it up, otherwise we would have to create a special EmptyShape or something.  But I agree with you that in this case there should be no question mark.  I'll fix that separately.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101517/#review3720
-----------------------------------------------------------


On June 6, 2011, 8:40 a.m., Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101517/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 8:40 a.m.)
> 
> 
> Review request for Calligra, Boudewijn Rempt, Thorsten Zachmann, and Inge Wallin.
> 
> 
> Summary
> -------
> 
> If there is empty frame in odt file calligra engine creates KoUnavailShape.
> 
> KoUnavailShape shows only question mark.
> I think it would be better to show background filling instead of question mark if there is some.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoUnavailShape.cpp 7f806d7 
> 
> Diff: http://git.reviewboard.kde.org/r/101517/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110608/271f1353/attachment.htm>