Review Request: KoUnavailShape should show background fill
Inge Wallin
inge at lysator.liu.se
Wed Jun 8 09:52:38 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101517/#review3760
-----------------------------------------------------------
Ship it!
Looks fine. On a side note: That was the most ugly text file I've ever seen. But it looks exactly the same in oowriter so that's not a bug. At least not in the application. :-)
- Inge
On June 6, 2011, 8:40 a.m., Matus Hanzes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101517/
> -----------------------------------------------------------
>
> (Updated June 6, 2011, 8:40 a.m.)
>
>
> Review request for Calligra, Boudewijn Rempt, Thorsten Zachmann, and Inge Wallin.
>
>
> Summary
> -------
>
> If there is empty frame in odt file calligra engine creates KoUnavailShape.
>
> KoUnavailShape shows only question mark.
> I think it would be better to show background filling instead of question mark if there is some.
>
>
> Diffs
> -----
>
> libs/flake/KoUnavailShape.cpp 7f806d7
>
> Diff: http://git.reviewboard.kde.org/r/101517/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110608/189fad02/attachment.htm>
More information about the calligra-devel
mailing list