<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101517/">http://git.reviewboard.kde.org/r/101517/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 6th, 2011, 1:29 p.m., <b>Thorsten Zachmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it be possible to see a document showing the problem?
Also I think if the frame is empty it might be a bad idea for the unavail shape to pick it up or to display something. However you fix seams to do something else and is nowhere checking if there is content or not.
</pre>
</blockquote>
<p>On June 7th, 2011, 1:05 p.m., <b>Matus Hanzes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://valdyas.org/~lukast/a.odt</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the problem with empty frames: I think the unavail shape should pick it up, otherwise we would have to create a special EmptyShape or something. But I agree with you that in this case there should be no question mark. I'll fix that separately.</pre>
<br />
<p>- Inge</p>
<br />
<p>On June 6th, 2011, 8:40 a.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Boudewijn Rempt, Thorsten Zachmann, and Inge Wallin.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated June 6, 2011, 8:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If there is empty frame in odt file calligra engine creates KoUnavailShape.
KoUnavailShape shows only question mark.
I think it would be better to show background filling instead of question mark if there is some.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoUnavailShape.cpp <span style="color: grey">(7f806d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101517/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>