Review Request: Return support for clone layers of group layers

[Torio Mlshi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101928/
-----------------------------------------------------------

(Updated July 12, 2011, 4:38 p.m.)


Review request for Calligra.


Changes
-------

Now it has more checking for circles, so it can work with complex situations.  Due to recursive design it should probably find all possible circles.

Dmitry, I've already fixed that by adding new getNewNodeLocation function which gets node instead of node type (and so it calls node->allowAsChild).


Summary
-------

Also add checking if clone layer could be moved to group layer not causing cyclic behaviour.


This addresses bug 270753.
    http://bugs.kde.org/show_bug.cgi?id=270753


Diffs (updated)
-----

  krita/image/kis_clone_layer.h a61590a4333ee209da392488945dc04f9d254c77 
  krita/image/kis_clone_layer.cpp 76380802ba2b285a2c9ae6b9fb38d332403ac813 
  krita/image/kis_group_layer.cc 83bd15b11ec6f0c8ed2a1850e28cd844eb21a793 
  krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 921bc533f26c4dd2cb03c800b5f863fcd4c1a6d3 
  krita/ui/kis_layer_manager.cc fa68be1d65399ba0bdc2c0197826b23ef7201335 
  krita/ui/kis_node_manager.h 92ee062f79dbaffd88f684e56f203c6d7da7d0c8 
  krita/ui/kis_node_manager.cpp 4ed6a9be5af2e246666f7a21c32227ed0ddfbfe0 

Diff: http://git.reviewboard.kde.org/r/101928/diff


Testing
-------


Thanks,

Torio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110712/80ef87fc/attachment.htm>