<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101928/">http://git.reviewboard.kde.org/r/101928/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Torio Mlshi.</div>
<p style="color: grey;"><i>Updated July 12, 2011, 4:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now it has more checking for circles, so it can work with complex situations. Due to recursive design it should probably find all possible circles.
Dmitry, I've already fixed that by adding new getNewNodeLocation function which gets node instead of node type (and so it calls node->allowAsChild).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also add checking if clone layer could be moved to group layer not causing cyclic behaviour.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=270753">270753</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/kis_clone_layer.h <span style="color: grey">(a61590a4333ee209da392488945dc04f9d254c77)</span></li>
<li>krita/image/kis_clone_layer.cpp <span style="color: grey">(76380802ba2b285a2c9ae6b9fb38d332403ac813)</span></li>
<li>krita/image/kis_group_layer.cc <span style="color: grey">(83bd15b11ec6f0c8ed2a1850e28cd844eb21a793)</span></li>
<li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span style="color: grey">(921bc533f26c4dd2cb03c800b5f863fcd4c1a6d3)</span></li>
<li>krita/ui/kis_layer_manager.cc <span style="color: grey">(fa68be1d65399ba0bdc2c0197826b23ef7201335)</span></li>
<li>krita/ui/kis_node_manager.h <span style="color: grey">(92ee062f79dbaffd88f684e56f203c6d7da7d0c8)</span></li>
<li>krita/ui/kis_node_manager.cpp <span style="color: grey">(4ed6a9be5af2e246666f7a21c32227ed0ddfbfe0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101928/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>