Review Request: Return support for clone layers of group layers

Dmitry Kazakov dimula73 at gmail.com
Tue Jul 12 17:20:50 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101928/#review4650
-----------------------------------------------------------


There is one old problem in KisNodeManager (will be revealed by the patch). KisNodeManager does not call node->allowAsChild() when a node is moved. Instead it calls internal version of allowAsChild() (kis_node_manager.cpp:275). So you'll have to fix it as well to allow creation of clones for the group layers.

- Dmitry


On July 12, 2011, 11:37 a.m., Torio Mlshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101928/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 11:37 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Also add checking if clone layer could be moved to group layer not causing cyclic behaviour.
> 
> 
> This addresses bug 270753.
>     http://bugs.kde.org/show_bug.cgi?id=270753
> 
> 
> Diffs
> -----
> 
>   krita/image/kis_clone_layer.h a61590a 
>   krita/image/kis_clone_layer.cpp 7638080 
>   krita/image/kis_group_layer.cc 83bd15b 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 921bc53 
>   krita/ui/kis_layer_manager.cc fa68be1 
>   krita/ui/kis_node_manager.h 92ee062 
>   krita/ui/kis_node_manager.cpp 4ed6a9b 
> 
> Diff: http://git.reviewboard.kde.org/r/101928/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/calligra-devel/attachments/20110712/5f5dfc83/attachment.htm 


More information about the calligra-devel mailing list