<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101928/">http://git.reviewboard.kde.org/r/101928/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is one old problem in KisNodeManager (will be revealed by the patch). KisNodeManager does not call node->allowAsChild() when a node is moved. Instead it calls internal version of allowAsChild() (kis_node_manager.cpp:275). So you'll have to fix it as well to allow creation of clones for the group layers.</pre>
<br />
<p>- Dmitry</p>
<br />
<p>On July 12th, 2011, 11:37 a.m., Torio Mlshi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Torio Mlshi.</div>
<p style="color: grey;"><i>Updated July 12, 2011, 11:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also add checking if clone layer could be moved to group layer not causing cyclic behaviour.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=270753">270753</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/image/kis_clone_layer.h <span style="color: grey">(a61590a)</span></li>
<li>krita/image/kis_clone_layer.cpp <span style="color: grey">(7638080)</span></li>
<li>krita/image/kis_group_layer.cc <span style="color: grey">(83bd15b)</span></li>
<li>krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp <span style="color: grey">(921bc53)</span></li>
<li>krita/ui/kis_layer_manager.cc <span style="color: grey">(fa68be1)</span></li>
<li>krita/ui/kis_node_manager.h <span style="color: grey">(92ee062)</span></li>
<li>krita/ui/kis_node_manager.cpp <span style="color: grey">(4ed6a9b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101928/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>