Review Request: more parentheris for ? operator and other things

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101818/#review4300
-----------------------------------------------------------

Ship it!


Besides the 2 changes I added a comment to it looks good. It would be good if some other people had a look that them. Please fix the issues pointed out and commit


filters/words/msword-odf/mswordodfimport.cpp
<http://git.reviewboard.kde.org/r/101818/#comment3528>

    According to our coding style this should be written "const InvalidFormatException &_e" so the space is before and not after the &. Please fix all occurences of that



filters/words/mswrite/mswriteimport.cc
<http://git.reviewboard.kde.org/r/101818/#comment3529>

    



plugins/chartshape/kdchart/src/KDChartCartesianAxis.cpp
<http://git.reviewboard.kde.org/r/101818/#comment3530>

    I guess that should be 
    
       if( qAbs( (mayBeTick - diagramIsVertical != 0) ? leftPoint.y() : leftPoint.x() ) > 1 ){



tables/PrintSettings.cpp
<http://git.reviewboard.kde.org/r/101818/#comment3531>

    Nice catch
    


- Thorsten


On July 1, 2011, 6:04 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101818/
> -----------------------------------------------------------
> 
> (Updated July 1, 2011, 6:04 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> I should not mix so many patches, but I still have some trouble with git stash and similar.
> I hope this time the parenthesis for the ? operator are safe. (last group of them).
> Last group of exceptions to const exceptions&
> Two = operators that should return class&
> And one variable and a parameter missing in tables. (last group of same expresion in both sides of ==).
> 
> 
> Diffs
> -----
> 
>   filters/tables/xlsx/NumberFormatParser.cpp c686cdc 
>   filters/words/msword-odf/mswordodfimport.cpp baf667c 
>   filters/words/mswrite/mswriteimport.cc dfc39b5 
>   kexi/kexidb/drivers/oracle/oracleconnection.cpp c2e96f9 
>   kexi/kexidb/drivers/oracle/oracleconnection_p.cpp be7c125 
>   kexi/kexidb/drivers/oracle/oraclecursor.cpp ff4e66e 
>   krita/plugins/extensions/tonemapping/operators/trilateral/pfstmo_trilateral.cpp f8f55b3 
>   krita/plugins/tools/tool_curves/kis_curve_framework.h 6f9a79c 
>   plugins/chartshape/kdchart/src/KDChartCartesianAxis.cpp cbf0d66 
>   plugins/reporting/barcode/codeean.cpp 0d70f39 
>   plugins/reporting/barcode/codeeanpaint.cpp 0542417 
>   tables/PrintSettings.cpp ff785da 
>   tables/commands/AutoFillCommand.cpp ef52d28 
>   tables/database/Filter.cpp 3b01637 
> 
> Diff: http://git.reviewboard.kde.org/r/101818/diff
> 
> 
> Testing
> -------
> 
> I can not test them. I'm using gcc 4.6.1 and can not compile.
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110702/d0e7e537/attachment.htm>