<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101818/">http://git.reviewboard.kde.org/r/101818/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides the 2 changes I added a comment to it looks good. It would be good if some other people had a look that them. Please fix the issues pointed out and commit</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101818/diff/1/?file=25770#file25770line209" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/msword-odf/mswordodfimport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KoFilter::ConversionStatus MSWordOdfImport::convert(const QByteArray &from, const QByteArray &to)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">209</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">catch</span> <span class="p">(</span><span class="n">InvalidFormatException</span> <span class="n">_e</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">209</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">catch</span> <span class="p">(</span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">InvalidFormatException</span><span class="o"><span class="hl">&</span></span> <span class="n">_e</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to our coding style this should be written "const InvalidFormatException &_e" so the space is before and not after the &. Please fix all occurences of that</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101818/diff/1/?file=25771#file25771line175" style="color: black; font-weight: bold; text-decoration: underline;">filters/words/mswrite/mswriteimport.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">175</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">WRIObject</span> <span class="k">operator</span><span class="o">=</span> <span class="p">(</span><span class="k">const</span> <span class="n">WRIObject</span> <span class="o">&</span><span class="n">rhs</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">175</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">WRIObject</span><span class="o"><span class="hl">&</span></span> <span class="k">operator</span><span class="o">=</span> <span class="p">(</span><span class="k">const</span> <span class="n">WRIObject</span> <span class="o">&</span><span class="n">rhs</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"></pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101818/diff/1/?file=25777#file25777line308" style="color: black; font-weight: bold; text-decoration: underline;">plugins/chartshape/kdchart/src/KDChartCartesianAxis.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CartesianAxis::Private::drawSubUnitRulers( QPainter* painter, CartesianCoordinatePlane* plane, const DataDimension& dim,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">308</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">qAbs</span><span class="p">(</span> <span class="n">mayBeTick</span> <span class="o">-</span> <span class="n">diagramIsVertical</span> <span class="o">?</span> <span class="n">leftPoint</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span class="o">:</span> <span class="n">leftPoint</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span class="p">)</span> <span class="o">></span> <span class="mi">1</span> <span class="p">){</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">308</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">qAbs</span><span class="p">(</span> <span class="p"><span class="hl">(</span></span><span class="n">mayBeTick</span> <span class="o">-</span> <span class="n">diagramIsVertical</span><span class="hl"> </span><span class="o"><span class="hl">></span></span><span class="mi"><span class="hl">0</span></span><span class="p"><span class="hl">)</span></span> <span class="o">?</span> <span class="n">leftPoint</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span class="o">:</span> <span class="n">leftPoint</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span class="p">)</span> <span class="o">></span> <span class="mi">1</span> <span class="p">){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess that should be
if( qAbs( (mayBeTick - diagramIsVertical != 0) ? leftPoint.y() : leftPoint.x() ) > 1 ){</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101818/diff/1/?file=25780#file25780line399" style="color: black; font-weight: bold; text-decoration: underline;">tables/PrintSettings.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString PrintSettings::saveOdfPageLayout(KoGenStyles &mainStyles,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">399</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">center<span class="hl">Horizont</span>ally</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">399</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">center<span class="hl">Vertic</span>ally</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice catch
</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On July 1st, 2011, 6:04 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated July 1, 2011, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I should not mix so many patches, but I still have some trouble with git stash and similar.
I hope this time the parenthesis for the ? operator are safe. (last group of them).
Last group of exceptions to const exceptions&
Two = operators that should return class&
And one variable and a parameter missing in tables. (last group of same expresion in both sides of ==).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can not test them. I'm using gcc 4.6.1 and can not compile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/tables/xlsx/NumberFormatParser.cpp <span style="color: grey">(c686cdc)</span></li>
<li>filters/words/msword-odf/mswordodfimport.cpp <span style="color: grey">(baf667c)</span></li>
<li>filters/words/mswrite/mswriteimport.cc <span style="color: grey">(dfc39b5)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection.cpp <span style="color: grey">(c2e96f9)</span></li>
<li>kexi/kexidb/drivers/oracle/oracleconnection_p.cpp <span style="color: grey">(be7c125)</span></li>
<li>kexi/kexidb/drivers/oracle/oraclecursor.cpp <span style="color: grey">(ff4e66e)</span></li>
<li>krita/plugins/extensions/tonemapping/operators/trilateral/pfstmo_trilateral.cpp <span style="color: grey">(f8f55b3)</span></li>
<li>krita/plugins/tools/tool_curves/kis_curve_framework.h <span style="color: grey">(6f9a79c)</span></li>
<li>plugins/chartshape/kdchart/src/KDChartCartesianAxis.cpp <span style="color: grey">(cbf0d66)</span></li>
<li>plugins/reporting/barcode/codeean.cpp <span style="color: grey">(0d70f39)</span></li>
<li>plugins/reporting/barcode/codeeanpaint.cpp <span style="color: grey">(0542417)</span></li>
<li>tables/PrintSettings.cpp <span style="color: grey">(ff785da)</span></li>
<li>tables/commands/AutoFillCommand.cpp <span style="color: grey">(ef52d28)</span></li>
<li>tables/database/Filter.cpp <span style="color: grey">(3b01637)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101818/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>