Review Request: more parentheris for ? operator and other things
Jaime Torres Amate
jtamate at gmail.com
Fri Jul 1 19:04:49 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101818/
-----------------------------------------------------------
Review request for Calligra.
Summary
-------
I should not mix so many patches, but I still have some trouble with git stash and similar.
I hope this time the parenthesis for the ? operator are safe. (last group of them).
Last group of exceptions to const exceptions&
Two = operators that should return class&
And one variable and a parameter missing in tables. (last group of same expresion in both sides of ==).
Diffs
-----
filters/tables/xlsx/NumberFormatParser.cpp c686cdc
filters/words/msword-odf/mswordodfimport.cpp baf667c
filters/words/mswrite/mswriteimport.cc dfc39b5
kexi/kexidb/drivers/oracle/oracleconnection.cpp c2e96f9
kexi/kexidb/drivers/oracle/oracleconnection_p.cpp be7c125
kexi/kexidb/drivers/oracle/oraclecursor.cpp ff4e66e
krita/plugins/extensions/tonemapping/operators/trilateral/pfstmo_trilateral.cpp f8f55b3
krita/plugins/tools/tool_curves/kis_curve_framework.h 6f9a79c
plugins/chartshape/kdchart/src/KDChartCartesianAxis.cpp cbf0d66
plugins/reporting/barcode/codeean.cpp 0d70f39
plugins/reporting/barcode/codeeanpaint.cpp 0542417
tables/PrintSettings.cpp ff785da
tables/commands/AutoFillCommand.cpp ef52d28
tables/database/Filter.cpp 3b01637
Diff: http://git.reviewboard.kde.org/r/101818/diff
Testing
-------
I can not test them. I'm using gcc 4.6.1 and can not compile.
Thanks,
Jaime Torres
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110701/29eab874/attachment.htm>
More information about the calligra-devel
mailing list