Review Request: Patch for using KoAbstractionController directly from FreOffice

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100462/#review1132
-----------------------------------------------------------


I wonder what happens if you move the signals. It will be not possible to connect to them in KoAbstractApplicationController code since KoAbstractApplicationController cannot inherit QObject. The hack with including .moc file was to avoid this. If we want to clean up things, please propose better alternative (not known for me now).

Do you need the change only for aesthetic purposes or is there a technical problem?


- Jarosław


On Jan. 31, 2011, 12:07 p.m., Mani Chandrasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100462/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2011, 12:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch removes KoAbstraction class which implements KoAbstractionContorller. 
> 
> Since we are reimplementing most of the functions in MainWindow.cpp I have removed KoAbstraction class and moved all the signals to MainWindow
> I feel the implementation should be in freoffice code instead of abstraction library. 
> 
> Is there any possible drawbacks in this approach? 
> 
> 
> Diffs
> -----
> 
>   tools/CMakeLists.txt d4e6ab5 
>   tools/f-office/CMakeLists.txt a212bc0 
>   tools/f-office/MainWindow.h f7b6149 
>   tools/f-office/MainWindow.cpp 549b7d1 
> 
> Diff: http://git.reviewboard.kde.org/r/100462/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110131/f514fd10/attachment.htm>