<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100462/">http://git.reviewboard.kde.org/r/100462/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder what happens if you move the signals. It will be not possible to connect to them in KoAbstractApplicationController code since KoAbstractApplicationController cannot inherit QObject. The hack with including .moc file was to avoid this. If we want to clean up things, please propose better alternative (not known for me now).
Do you need the change only for aesthetic purposes or is there a technical problem?
</pre>
<br />
<p>- Jarosław</p>
<br />
<p>On January 31st, 2011, 12:07 p.m., Mani Chandrasekar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Mani Chandrasekar.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2011, 12:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes KoAbstraction class which implements KoAbstractionContorller.
Since we are reimplementing most of the functions in MainWindow.cpp I have removed KoAbstraction class and moved all the signals to MainWindow
I feel the implementation should be in freoffice code instead of abstraction library.
Is there any possible drawbacks in this approach? </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tools/CMakeLists.txt <span style="color: grey">(d4e6ab5)</span></li>
<li>tools/f-office/CMakeLists.txt <span style="color: grey">(a212bc0)</span></li>
<li>tools/f-office/MainWindow.h <span style="color: grey">(f7b6149)</span></li>
<li>tools/f-office/MainWindow.cpp <span style="color: grey">(549b7d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100462/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>