Review Request: Patch for using KoAbstractionController directly from FreOffice

Mani Chandrasekar maninc at gmail.com
Mon Jan 31 12:07:51 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100462/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

This patch removes KoAbstraction class which implements KoAbstractionContorller. 

Since we are reimplementing most of the functions in MainWindow.cpp I have removed KoAbstraction class and moved all the signals to MainWindow
I feel the implementation should be in freoffice code instead of abstraction library. 

Is there any possible drawbacks in this approach? 


Diffs
-----

  tools/CMakeLists.txt d4e6ab5 
  tools/f-office/CMakeLists.txt a212bc0 
  tools/f-office/MainWindow.h f7b6149 
  tools/f-office/MainWindow.cpp 549b7d1 

Diff: http://git.reviewboard.kde.org/r/100462/diff


Testing
-------


Thanks,

Mani

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110131/4ab7369a/attachment.htm>


More information about the calligra-devel mailing list