Review Request: Implement saving for the KoUnavailShape

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100629/#review2449
-----------------------------------------------------------



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2094>

    Please remove the blanks between the type and the variable name.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2095>

    Please remove the blanks between the type and the variable name.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2096>

    Please remove the code if it is no longer needed.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2097>

    Please remove if it is not needed.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2098>

    Please remove the function as there is nothing done here so the default implementation of KoShape can be used



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2099>

    Please remove the unneeded blanks before =



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2100>

    Please remove if it is no longer needed.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2101>

    Please remove the blanks after the type and before the variable name



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2102>

    Please remove the additional blanks after the type and before the variable.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2103>

    Please remove the additional blanks after the type and before the variable.



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2104>

    Please remove the additional blanks after the type and before the variable.



libs/odf/KoEmbeddedDocumentSaver.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2106>

    Please remove the additional blanks after the type and before the variable.



libs/odf/KoEmbeddedDocumentSaver.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2107>

    Please remove the additional blanks after the type and before the variable.



libs/odf/KoEmbeddedDocumentSaver.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2108>

    Please remove the additional blanks after the type and before the variable.



libs/odf/KoOdfManifest.h
<http://git.reviewboard.kde.org/r/100629/#comment2109>

    Please rename the file to KoOdfManifestEntry.h



libs/odf/KoOdfManifest.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2110>

    Please rename the file to match the classname



libs/odf/KoOdfManifest.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2111>

    The constructor is not needed and can be removed



plugins/vectorshape/VectorShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2112>

    Should it really saved? Or would it be better to not save it in case that happens.


- Thorsten


On April 1, 2011, 3:44 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100629/
> -----------------------------------------------------------
> 
> (Updated April 1, 2011, 3:44 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch implements saving in the KoUnavailShape.
> 
> The method it uses is to introduce a new class, KoEmbeddedFileSaver, in koodf. This class is a bit like the KoEmbeddedObjectSaver class, and is created and instantiated in the same places. It is also part of the KoShapeSavingContext.
> 
> As a bonus, this patch also implements saving for the Vector shape, since I used that for testing in early stages.
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoOdfManifest.h PRE-CREATION 
>   libs/odf/KoOdfLoadingContext.h 023b92f 
>   libs/odf/KoOdfLoadingContext.cpp ce53992 
>   libs/odf/CMakeLists.txt 668ba51 
>   libs/odf/KoEmbeddedDocumentSaver.h 11cf075 
>   libs/odf/KoEmbeddedDocumentSaver.cpp a8e13d8 
>   libs/flake/KoUnavailShape.cpp 3f10acf 
>   libs/odf/KoOdfManifest.cpp PRE-CREATION 
>   plugins/vectorshape/VectorShape.cpp 3229341 
> 
> Diff: http://git.reviewboard.kde.org/r/100629/diff
> 
> 
> Testing
> -------
> 
> Tested with a simple odt file with an embedded spreadsheet.
> 
> 
> Thanks,
> 
> Inge
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110407/a9dea7ee/attachment.htm>