Review Request: Implement saving for the KoUnavailShape

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100629/
-----------------------------------------------------------

(Updated April 1, 2011, 3:44 p.m.)


Review request for Calligra.


Changes
-------

Here is version 3 of the diff. I implemented all comments, and also removed everything that's not the core change.

I know also know why OOo doesn't like the files that I write.  Apparently, OOo needs embedded objects to be called "Object<num>"; UObject<num> is not good.  This is contrary to the spec, that says that objects could be named anything.  If this diff is Ok'ed, I will go through all the source code of Calligra and make sure that all objects are named through calls to getFileName() and not created ad hoc.  Right now, I can't call the objects Object<num> since that may create collisions with objects created by other parts of Calligra. Then OOo will also be able to read our files.


Summary
-------

This patch implements saving in the KoUnavailShape.

The method it uses is to introduce a new class, KoEmbeddedFileSaver, in koodf. This class is a bit like the KoEmbeddedObjectSaver class, and is created and instantiated in the same places. It is also part of the KoShapeSavingContext.

As a bonus, this patch also implements saving for the Vector shape, since I used that for testing in early stages.


Diffs (updated)
-----

  libs/odf/KoOdfManifest.h PRE-CREATION 
  libs/odf/KoOdfLoadingContext.h 023b92f 
  libs/odf/KoOdfLoadingContext.cpp ce53992 
  libs/odf/CMakeLists.txt 668ba51 
  libs/odf/KoEmbeddedDocumentSaver.h 11cf075 
  libs/odf/KoEmbeddedDocumentSaver.cpp a8e13d8 
  libs/flake/KoUnavailShape.cpp 3f10acf 
  libs/odf/KoOdfManifest.cpp PRE-CREATION 
  plugins/vectorshape/VectorShape.cpp 3229341 

Diff: http://git.reviewboard.kde.org/r/100629/diff


Testing
-------

Tested with a simple odt file with an embedded spreadsheet.


Thanks,

Inge

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110401/417ca67c/attachment.htm>