Review Request: Implement saving for the KoUnavailShape

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100629/#review2627
-----------------------------------------------------------


Ok, fixed it all except for the issue in the vector shape and one disabled block of debug code.


libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2295>

    The comment says "Enable to get more detailed debug messages." If I remember correctly, this is what you told me to do in an earlier review, so you are arguing against yourself.
    
    That said, I think this should be kept.



libs/odf/KoOdfManifest.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2297>

    Right.  In the beginning, I thought to have a class to handle the manifest as well, but that didn't happen so far.



plugins/vectorshape/VectorShape.cpp
<http://git.reviewboard.kde.org/r/100629/#comment2296>

    Good question.  What's your suggestion?


- Inge


On April 1, 2011, 3:44 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100629/
> -----------------------------------------------------------
> 
> (Updated April 1, 2011, 3:44 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> This patch implements saving in the KoUnavailShape.
> 
> The method it uses is to introduce a new class, KoEmbeddedFileSaver, in koodf. This class is a bit like the KoEmbeddedObjectSaver class, and is created and instantiated in the same places. It is also part of the KoShapeSavingContext.
> 
> As a bonus, this patch also implements saving for the Vector shape, since I used that for testing in early stages.
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoOdfManifest.h PRE-CREATION 
>   libs/odf/KoOdfLoadingContext.h 023b92f 
>   libs/odf/KoOdfLoadingContext.cpp ce53992 
>   libs/odf/CMakeLists.txt 668ba51 
>   libs/odf/KoEmbeddedDocumentSaver.h 11cf075 
>   libs/odf/KoEmbeddedDocumentSaver.cpp a8e13d8 
>   libs/flake/KoUnavailShape.cpp 3f10acf 
>   libs/odf/KoOdfManifest.cpp PRE-CREATION 
>   plugins/vectorshape/VectorShape.cpp 3229341 
> 
> Diff: http://git.reviewboard.kde.org/r/100629/diff
> 
> 
> Testing
> -------
> 
> Tested with a simple odt file with an embedded spreadsheet.
> 
> 
> Thanks,
> 
> Inge
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110414/507ce2a7/attachment.htm>