[Patch] Allow toolbar to be completely detached as a window

[Thomas Lübking]

Hi Nikhil,

First of all, thanks for the patch but:
It can /not/ be applied atm. and the way it is*, as the 
"topLevelChanged(bool)" signal is introduced with Qt 4.6, which is currently 
not a required base of Amarok :-(
(if you don't read this list on a regular base - i ran into similar traps 
before ;-)

About the patch itself:
-----------------
- i don't like too much that you need to close the toolbar to reparent it into 
the mainwindow :-\

- the keep active thing is merely a windowflag, hinting to the WM (e.g. KWin) 
-> this should be achievable by telling the WM that "we wish to gain focus" or 
"deal focus ourself" (what would preserve the drag and drop reparenting 
feature :) even w/o changing the window type** (thus maybe confusing Qt's 
mainlayout code)

- mousetracking should not be required (you receive mousemoves anyway as long 
as a button is pressed), also why not just use the toplevelchange signal 
directly? (_iff_ we could use it ;-)

- i also guess some ppl. oppose the title to be "Toolbar", should be more like 
"Amarok" ;-)

- the size issue is due to the custom layout and the lack of a set minimum 
size (and the fact that Qt collapses toolbars when floating them)

@Markey and the other chiefs (IMPORTANT basic question):
Does Amarok want a player window at all (again), i.e. is this a 
wished/acceptable feature (i think that has never been answered ;)

In this case i'd like to also adjust the layout (vertically align the tracks 
and the slider to get the thing more compact =)


Cheers,
Thomas

* i think there's still a way nevertheless =)
** what however would allow to get the toolbar into the window stack, i.e. 
allow it to be covered, etc.


Am Saturday 20 March 2010 schrieb Nikhil Marathe:
> Hi all,
> 
> I have modified the Main Toolbar so that when it is made floating,
> rather than simply retaining the fake toolbar window, it creates a
> proper window of its own.
> This allows the main window to be minimized etc, while still keeping
> the toolbar active, somewhat like Amarok 1.4 had a separate window. I
> believe this is
> an improvement over the current detachment. The technique I've used is
> to listen for mouse events and create a new window with a new instance
> of the toolbar. There is one problem: The tracks toolbar doesn't
> expand to its full size, and I can't seem to figure out how to make it
> do so. The git
> commit message details the procedure. I hope it is useful and gets in.
> 
> PS. I'm not sure how to send patches to the Amarok ML, inline or
> attached, so attaching as git format-patch output.
> 
> Regards,
> Nikhil