questions about CD audio changing track

[Nikolaj Hald Nielsen]

Hi Luc

The reason for calling slotAboutToFinish() is that Phonon does not
automatically stop after playing one track on a CD, so if your CD
tracks in the playlist are not in the same order they are on the CD,
or are mixed up with non CD tracks, it will cause issues.

You are right that playing consecutive tracks off a CD should be
handled more gracefully, as there is currently also a "gap" in
playback when advancing to the next track that really does not need to
be there. The thing is that getting the engine controller to know
whether the next track is the consecutive track on a CD is slightly
tricky and something I did not have time to implement for 2.2.0. It is
on my todo list though.

- Nikolaj

On Sun, Sep 27, 2009 at 7:09 PM, Luc Menut <lmenut at mandriva.org> wrote:
> Hi,
>
> I'm a Mandriva contributor, and currently I'm trying to fix some bugs in
> phonon-gstreamer, particularly in order to have amarok 2.2 working with
> phonon-gstreamer.
>
> I have some questions about the way changing CD audio track is done in
> amarok.
>
> In EngineController.cpp, you connect the signal titleChanged from the
> media controller to slotTitleChanged, and in slotTitleChanged you call
> slotAboutToFinish().
> Why do you do this?
> That seems me odd, because titleChanged is emitted when the track is
> changed, at the beginning of the track, and slotAboutToFinish is
> geenrally used at the end of a track.
> To avoid a loop when changing track, in playUrl you disconnect
> titleChanged at the beginning, and reconnect it at the end. You assume
> that titleChanged is emitted immmediately after
> setCurrentTitle(trackNumber) is called.
> But this isn't always the case.
> If there is a little delay between the call of setCurrentTitle and the
> time when titleChanged is emmited, titleChanged is already reconnected
> to slotTitleChnaged, and tracks are changed in loop.
> That's what we have with phonon-gstreamer.
>
> btw, why don't you let phonon's autoplayTitles play successively the
> tracks when they are continuous, and disable autoplay when tracks in
> playlist are not continuous.
>
>
> regards,
>
> Luc
>
>
> PS: i'm french, sorry for my bad english.
>
> --
> Luc Menut
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>