questions about CD audio changing track

[Luc Menut]

Hi,

I'm a Mandriva contributor, and currently I'm trying to fix some bugs in 
phonon-gstreamer, particularly in order to have amarok 2.2 working with 
phonon-gstreamer.

I have some questions about the way changing CD audio track is done in 
amarok.

In EngineController.cpp, you connect the signal titleChanged from the 
media controller to slotTitleChanged, and in slotTitleChanged you call 
slotAboutToFinish().
Why do you do this?
That seems me odd, because titleChanged is emitted when the track is 
changed, at the beginning of the track, and slotAboutToFinish is 
geenrally used at the end of a track.
To avoid a loop when changing track, in playUrl you disconnect 
titleChanged at the beginning, and reconnect it at the end. You assume 
that titleChanged is emitted immmediately after 
setCurrentTitle(trackNumber) is called.
But this isn't always the case.
If there is a little delay between the call of setCurrentTitle and the 
time when titleChanged is emmited, titleChanged is already reconnected 
to slotTitleChnaged, and tracks are changed in loop.
That's what we have with phonon-gstreamer.

btw, why don't you let phonon's autoplayTitles play successively the 
tracks when they are continuous, and disable autoplay when tracks in 
playlist are not continuous.


regards,

Luc


PS: i'm french, sorry for my bad english.

-- 
Luc Menut