branches/stable/extragear/multimedia/amarok

[Seb Ruiz]

SVN commit 715714 by seb:

Always rebuild the dynamic mode cache when in Suggested songs mode, so that we don't land up with stale suggestions
CCMAIL: amarok at kde.org


 M  +5 -2      ChangeLog  
 M  +2 -1      src/dynamicmode.cpp  


--- branches/stable/extragear/multimedia/amarok/ChangeLog #715713:715714
@@ -5,8 +5,11 @@
 
 VERSION 1.4.8
   BUGFIXES:
-    *  Sort albums made in the same year alphabetically in 'ascending
-    order'.  (BR 149408)
+    * Always rebuild the dynamic mode cache when in Suggested songs mode,
+      so that we don't land up with stale suggestions. Patch by Jer Johnson
+      <jer at gweep.net>
+    * Sort albums made in the same year alphabetically in 'ascending
+      order'. (BR 149408)
     * Statistics tool shouldn't show samplers in 'favorite albums'.
     * Duplicate songs were not allowed in playlist when adding from the
       collection browser. (BR 149643)
--- branches/stable/extragear/multimedia/amarok/src/dynamicmode.cpp #715713:715714
@@ -380,7 +380,8 @@
 DEBUG_BLOCK
     KURL::List retrieval;
 
-    if( m_cachedItemSet.count() <= trackCount )
+    // always rebuild with suggested mode since the artists will be changing
+    if( m_cachedItemSet.count() <= trackCount || appendType() == SUGGESTION )
         rebuildCachedItemSet();
 
     for( uint i=0; i < trackCount; i++ )