extragear/multimedia/amarok/src

Jeff Mitchell kde-dev at emailgoeshere.com
Wed Sep 20 02:08:34 UTC 2006


Didn't we add it for some specific reason?

--Jeff

Quoting Mark Kretschmann <markey at web.de>:

> SVN commit 583707 by markey:
>
> No longer do VACUUM with SQLite on shutdown. Takes too long, so   
> we're potentially risking to get killed before finishing.
>
>
>  M  +7 -5      collectiondb.cpp
>
>
> --- trunk/extragear/multimedia/amarok/src/collectiondb.cpp #583706:583707
> @@ -274,11 +274,13 @@
>          close( INotify::instance()->fd() );
>  #endif
>
> -    if ( getDbConnectionType() == DbConnection::sqlite )
> -    {
> -        debug() << "Running VACUUM" << endl;
> -        query( "VACUUM;" );
> -    }
> +// Disabled because VACUUM takes too long, which can lead to KDE   
> killing Amarok
> +// on shutdown.. which is really bad mojo.
> +//    if ( getDbConnectionType() == DbConnection::sqlite )
> +//    {
> +//        debug() << "Running VACUUM" << endl;
> +//        query( "VACUUM;" );
> +//    }
>
>      destroy();
>  }
>





More information about the Amarok mailing list