max.howell at methylblue.com
Fri Sep 22 23:38:05 UTC 2006
Jeff Mitchell wrote:
> Right...I wasn't concerned that the commits changed the behavior of
> the existing code, but rather, should we change the behavior anyways.
> I've run into situations before where a string is empty but not null,
> but should be treated the same way in either case. It was more a
> "should this be our policy" type thing :-)
> Quoting Andrew Turner <andrewturner512 at googlemail.com>:
>> If you look again at the commit message,
>> foo == QString::null
>> has been turned into
Some Qt stuff requires comparison with null, some empty, so don't change
everything as you may introduce new and subtle bugs.
More information about the Amarok