extragear/multimedia/amarok/src

[Alexandre Oliveira]

Vacuum cleans up the database, releasing not used space and
defragmentating. However, it was too slow, and when users were
shutting down their computers Vacuum wouldn't have time to finish,
leaving temporary files around. Not to mention that Amarok would get
killed instead of exiting, and thus some of the shutdown code could
actually never run.
Anyway, it shouldn't be necessary to run vaccum so often. We should
think about some other good time to run it.

On 9/19/06, Jeff Mitchell <kde-dev at emailgoeshere.com> wrote:
> Didn't we add it for some specific reason?
>
> --Jeff
>
> Quoting Mark Kretschmann <markey at web.de>:
>
> > SVN commit 583707 by markey:
> >
> > No longer do VACUUM with SQLite on shutdown. Takes too long, so
> > we're potentially risking to get killed before finishing.
> >
> >
> >  M  +7 -5      collectiondb.cpp
> >
> >
> > --- trunk/extragear/multimedia/amarok/src/collectiondb.cpp #583706:583707
> > @@ -274,11 +274,13 @@
> >          close( INotify::instance()->fd() );
> >  #endif
> >
> > -    if ( getDbConnectionType() == DbConnection::sqlite )
> > -    {
> > -        debug() << "Running VACUUM" << endl;
> > -        query( "VACUUM;" );
> > -    }
> > +// Disabled because VACUUM takes too long, which can lead to KDE
> > killing Amarok
> > +// on shutdown.. which is really bad mojo.
> > +//    if ( getDbConnectionType() == DbConnection::sqlite )
> > +//    {
> > +//        debug() << "Running VACUUM" << endl;
> > +//        query( "VACUUM;" );
> > +//    }
> >
> >      destroy();
> >  }
> >
>
>
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok
>