Magnatune Impressions

[Nikolaj Hald Nielsen]

Just one more note. I have actually gone out of my way to ensure that
the querries should run on SQLite, mysql and postgress, based on how
it was done in the existing amarok code.

- Nikolaj

On 9/16/06, Seb Ruiz <me at sebruiz.net> wrote:
> Hi Nikolaj
>
> I've just tested out the magnatune browser, and it works pretty well,
> i gotta say.  The interface is easy to use and I haven't experienced
> any blocking. Cool.
>
> But I do have some concerns:
>
>  - SQL queries are directly called from the magnatune browser.  This
> is a big nono, as strings aren't escaped, and you haven't taken into
> account the discrepancies with the different database backends.  The
> correct way to do this would be to add new fields to QueryBuilder and
> use a querybuilder to construct your query.
>
> - I don't like that magnatune browser being shown by default.  Perhaps
> a config option to enable it.
>
> - I hate that new "config" icon at the top of the browsers which lets
> you hide/show the browsers. I think it clutters the interface and
> reduces available realestate.  I think we should stick to the context
> menu.
>
>  - We use four spaces, not tabs.
>
>  - There is no magnatune icon!
>
> Cheers,
> Seb
>
> --
> http://www.sebruiz.net/
>