Regarding bug 130585

[Jeff Mitchell]

Joe--

I have an answer for you, but a question first -- can you verify that the 
entire comment that you type in is getting saved into the file's ID3v2 tag 
correctly?  I just want to make sure this is the case, and that we simply are 
only storing the first 256 bytes, rather than not storing the comment in the 
file (this would be bad if it were the case, since the tags table, or parts 
of it, gets dropped often).

Anyways, if you are talking about the comment field in the tags table, all you 
have to do is bump up the "static const int DATABASE_VERSION = 31" line in 
collectiondb.h to 32 (dealing with persistent tables, podcasts tables, or 
stats tables is much more difficult).

I'm not sure what your patch does, but please make sure that it's safe for all 
kinds of databases.  PostgreSQL has TEXT, MySQL has TEXT...does SQLite?

Also, your patch should probably be as easy as two lines: one to change the 
DATABASE_VERSION above, the other to change line 565 in collectiondb.cpp to 

"comment " + longTextColumnType() + ", "

(please make sure that longTextColumnType, which always returns "TEXT", works 
for SQLite as I said above).

--Jeff

On Friday 28 July 2006 15:35, Joseph Rabinoff wrote:
> Hi all,
>
> eean suggested that I post this question here.  I
> submitted a patch for bug 130585 (tag comment field
> too small), which basically says that if you have
> comments longer than 256 chars and you edit (any) tag
> from the playlist, you truncate your comments and make
> yourself annoyed because you spent hours typing in all
> of the members of the band into the comment field...
> Anyway, the truncation happens because tags.comment is
> VARCHAR(256) and not TEXT (whereas podcast*.comment is
> TEXT).  My patch just changes the table creation code
> in collectiondb.cpp, but eean says it's incomplete, as
> the database version needs to be bumped.  So can
> someone tell me what the procedure is for changing the
> database so I can submit a complete patch?
>
> Thanks a lot!
> Joe (QBob)
>
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
> _______________________________________________
> Amarok mailing list
> Amarok at kde.org
> https://mail.kde.org/mailman/listinfo/amarok