Review Request 129192: Add namespace to desktop and appdata files
Matěj Laitl
matej at laitl.cz
Sun Oct 16 10:47:29 UTC 2016
> On Říj. 16, 2016, 12:06 odp., Matěj Laitl wrote:
> > Looks good, but see one question below.
> >
> > Also, I wonder what the consequences would be? People loosing custom-set file associations? What about shortcuts in panels etc.?
I also think MediaPlayer2::DesktopEntry() needs to be updated.
- Matěj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129192/#review100035
-----------------------------------------------------------
On Říj. 15, 2016, 9:44 odp., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129192/
> -----------------------------------------------------------
>
> (Updated Říj. 15, 2016, 9:44 odp.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> - add the organization namespace to the desktop and then appdata files, according the specification;
> - use the new directory for metadata (metainfo) files.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 327ec10
> src/amarok.appdata.xml c580fd5
> src/amarok.desktop
> src/amarok_containers.desktop
>
> Diff: https://git.reviewboard.kde.org/r/129192/diff/
>
>
> Testing
> -------
>
> Compiles, the files are installed in the expected places.
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20161016/261b6357/attachment-0001.html>
More information about the Amarok-devel
mailing list