Review Request 129192: Add namespace to desktop and appdata files

[Luigi Toscano]

> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote:
> > Looks good, but see one question below.
> > 
> > Also, I wonder what the consequences would be? People loosing custom-set file associations? What about shortcuts in panels etc.?
> 
> Matěj Laitl wrote:
>     I also think MediaPlayer2::DesktopEntry() needs to be updated.

Right for MediaPlayer2.

It's possible that people would lose their favourite entry, if they linked to amarok desktop file. I'm not sure about associations, but I added the most knowledgable person about this to the review.


> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote:
> > src/CMakeLists.txt, lines 955-958
> > <https://git.reviewboard.kde.org/r/129192/diff/1/?file=482253#file482253line955>
> >
> >     What about these .desktop files? I seems that these should be moved, too, at least for consistency.

No, those are services. The specification talks about the reverse DNS syntax only for applications:
" For applications, the part of the name of the desktop file (before the .desktop) should follow the "reverse DNS" convention, e.g. org.example.FooViewer.desktop. "

https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129192/#review100035
-----------------------------------------------------------


On Ott. 15, 2016, 9:44 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129192/
> -----------------------------------------------------------
> 
> (Updated Ott. 15, 2016, 9:44 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> - add the organization namespace to the desktop and then appdata files, according the specification;
> - use the new directory for metadata (metainfo) files.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 327ec10 
>   src/amarok.appdata.xml c580fd5 
>   src/amarok.desktop  
>   src/amarok_containers.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/129192/diff/
> 
> 
> Testing
> -------
> 
> Compiles, the files are installed in the expected places.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20161016/f222212f/attachment.html>