Review Request 129192: Add namespace to desktop and appdata files

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129192/#review100035
-----------------------------------------------------------



Looks good, but see one question below.

Also, I wonder what the consequences would be? People loosing custom-set file associations? What about shortcuts in panels etc.?


src/CMakeLists.txt (lines 955 - 958)
<https://git.reviewboard.kde.org/r/129192/#comment67203>

    What about these .desktop files? I seems that these should be moved, too, at least for consistency.


- Matěj Laitl


On Říj. 15, 2016, 9:44 odp., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129192/
> -----------------------------------------------------------
> 
> (Updated Říj. 15, 2016, 9:44 odp.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> - add the organization namespace to the desktop and then appdata files, according the specification;
> - use the new directory for metadata (metainfo) files.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 327ec10 
>   src/amarok.appdata.xml c580fd5 
>   src/amarok.desktop  
>   src/amarok_containers.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/129192/diff/
> 
> 
> Testing
> -------
> 
> Compiles, the files are installed in the expected places.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20161016/d7b83f50/attachment.html>