Kf5 port(olivier)

[Olivier Churlaud]

> Le 14 sept. 2015 à 10:51, RISHABH GUPTA <rishabh9511 at gmail.com> a écrit :
> 
> 
>> ------------------------------
>> 
>> Message: 3
>> Date: Sun, 13 Sep 2015 17:59:49 -0000
>> From: "Olivier Churlaud" <olivier at churlaud.com>
>> To: "Olivier Churlaud" <olivier at churlaud.com>, "Amarok"
>>         <amarok-devel at kde.org>
>> Subject: Re: Review Request 125126: Port of main.cpp and App class
>> Message-ID: <20150913175949.3546.2737 at mimi.kde.org>
>> Content-Type: text/plain; charset="utf-8"
>> 
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://git.reviewboard.kde.org/r/125126/
>> -----------------------------------------------------------
>> 
>> (Updated sep. 13, 2015, 7:59 après-midi)
>> 
>> 
>> Review request for Amarok.
>> 
>> 
>> Changes
>> -------
>> 
>> Commented parts of code needing the context folder + changing all       Kio::Job job( 0 ) and derivated to job( )
>> 
>> here is the backtrace http://pastebin.com/s21KswyJ
>  
> hello,
> The backtrace you have provided doesn't show any error in app::continueinit()
> how is this possible? my output shows error in app::continueinit()
> 

This is what you should investigate. ContinueInit is done on my side.
Did you do make install?

>  #20 0x00007ffff6e4dfe5 in App::continueInit (this=0x7fffffffe460) at /home/rishabh/amaroksrc/src/amarok/src/App.cpp:516
> 
> just have a look at line 516 of app.cpp. I tried changing qmessagebox to kmessagebox of KF5 but that didn't help either.I think this should be sorted before we move further.Since i have not included your latest diff my output shows the old errors ,ignore them.
>  
> http://pastebin.com/jumc7adz
>  
> 
>> 
>> Repository: amarok
>> 
>> 
>> Description
>> -------
>> 
>> Port of main.cpp and App
>> 
>> It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().
>> I'm not able to trace it further.
>> 
>> Please help me to port well the main + App class so that the play, pause (and so one) commands are well read and to deal correctly with the unique/multiple instance.
>> 
>> 
>> Diffs (updated)
>> -----
>> 
>>   src/App.h 2089981
>>   src/App.cpp 6028bc8
>>   src/CMakeLists.txt afeef4a
>>   src/MainWindow.cpp d3bbc0b
>>   src/PluginManager.cpp a9a1c47
>>   src/TrayIcon.cpp be25497
>>   src/aboutdialog/libattica-ocsclient/activitylistjob.cpp 77044cf
>>   src/aboutdialog/libattica-ocsclient/categorylistjob.cpp 427011e
>>   src/aboutdialog/libattica-ocsclient/contentjob.cpp c307e07
>>   src/aboutdialog/libattica-ocsclient/contentlistjob.cpp d371db4
>>   src/aboutdialog/libattica-ocsclient/folderlistjob.cpp dc2c137
>>   src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp f678b56
>>   src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp a7d6b95
>>   src/aboutdialog/libattica-ocsclient/messagelistjob.cpp 372412d
>>   src/aboutdialog/libattica-ocsclient/personjob.cpp 455178c
>>   src/aboutdialog/libattica-ocsclient/personlistjob.cpp 005542b
>>   src/aboutdialog/libattica-ocsclient/postjob.cpp cce72a3
>>   src/amarok.desktop 433c757
>>   src/browsers/filebrowser/FileBrowser.cpp 3d40d9b
>>   src/configdialog/dialogs/ScriptsConfig.cpp bbec667
>>   src/context/engines/songkick/SongkickEngine.cpp 2291719
>>   src/core-impl/collections/db/sql/SqlCollectionLocation.cpp fe6bafd
>>   src/core/podcasts/PodcastReader.cpp 409fc62
>>   src/core/support/Components.cpp 9f97eb6
>>   src/main.cpp 385e047
>>   src/org.kde.amarok.desktop PRE-CREATION
>>   src/scanner/AbstractDirectoryWatcher.cpp 168c68a
>>   src/scanner/GenericScanManager.cpp 75a22cc
>>   src/scanner/GenericScannerJob.cpp a4558fd
>>   src/scripting/scriptmanager/ScriptManager.cpp bb62be1
>>   src/services/ServiceAlbumCoverDownloader.cpp d499f62
>>   src/services/lastfm/biases/WeeklyTopBias.cpp a12f9f7
>>   src/services/magnatune/MagnatuneAlbumDownloader.cpp 5fc6584
>>   src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 0c5913a
>>   src/services/opmldirectory/OpmlDirectoryInfoParser.cpp f6ac752
>> 
>> Diff: https://git.reviewboard.kde.org/r/125126/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().
>> 
>> I'm not able to trace it further.
>> 
>> 
>> Thanks,
>> 
>> Olivier Churlaud
> thanks,
> rishabh 
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150914/e820f5c0/attachment.html>