<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div><br>Le 14 sept. 2015 à 10:51, RISHABH GUPTA <<a href="mailto:rishabh9511@gmail.com">rishabh9511@gmail.com</a>> a écrit :<br><br></div><blockquote type="cite"><div><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
------------------------------<br>
<br>
Message: 3<br>
Date: Sun, 13 Sep 2015 17:59:49 -0000<br>
From: "Olivier Churlaud" <<a href="mailto:olivier@churlaud.com">olivier@churlaud.com</a>><br>
To: "Olivier Churlaud" <<a href="mailto:olivier@churlaud.com">olivier@churlaud.com</a>>, "Amarok"<br>
<<a href="mailto:amarok-devel@kde.org">amarok-devel@kde.org</a>><br>
Subject: Re: Review Request 125126: Port of main.cpp and App class<br>
Message-ID: <<a href="mailto:20150913175949.3546.2737@mimi.kde.org">20150913175949.3546.2737@mimi.kde.org</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="https://git.reviewboard.kde.org/r/125126/" rel="noreferrer" target="_blank">https://git.reviewboard.kde.org/r/125126/</a><br>
-----------------------------------------------------------<br>
<br>
(Updated sep. 13, 2015, 7:59 après-midi)<br>
<br>
<br>
Review request for Amarok.<br>
<br>
<br>
Changes<br>
-------<br>
<br>
Commented parts of code needing the context folder + changing all Kio::Job job( 0 ) and derivated to job( )<br>
<br>
here is the backtrace <a href="http://pastebin.com/s21KswyJ" rel="noreferrer" target="_blank">http://pastebin.com/s21KswyJ</a><br>
<br></blockquote><div> </div><div>hello,<br></div><div>The backtrace you have provided doesn't show any error in app::continueinit()<br></div><div>how is this possible? my output shows error in app::continueinit()<br><br></div></div></div></div></div></blockquote><div><br></div>This is what you should investigate. ContinueInit is done on my side.<div>Did you do make install?</div><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> #20 0x00007ffff6e4dfe5 in App::continueInit (this=0x7fffffffe460) at /home/rishabh/amaroksrc/src/amarok/src/App.cpp:516<br><br></div><div>just have a look at line 516 of app.cpp. I tried changing qmessagebox to kmessagebox of KF5 but that didn't help either.I think this should be sorted before we move further.Since i have not included your latest diff my output shows the old errors ,ignore them.<br> <br><a href="http://pastebin.com/jumc7adz">http://pastebin.com/jumc7adz</a><br></div> <a href="http://pastebin.com/Ka7cz7rZ" rel="noreferrer" target="_blank"> </a></div><div class="gmail_quote"><a href="http://pastebin.com/Ka7cz7rZ" rel="noreferrer" target="_blank"></a></div><div class="gmail_quote"><div> <br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Repository: amarok<br>
<br>
<br>
Description<br>
-------<br>
<br>
Port of main.cpp and App<br>
<br>
It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().<br>
I'm not able to trace it further.<br>
<br>
Please help me to port well the main + App class so that the play, pause (and so one) commands are well read and to deal correctly with the unique/multiple instance.<br>
<br>
<br>
Diffs (updated)<br>
-----<br>
<br>
src/App.h 2089981<br>
src/App.cpp 6028bc8<br>
src/CMakeLists.txt afeef4a<br>
src/MainWindow.cpp d3bbc0b<br>
src/PluginManager.cpp a9a1c47<br>
src/TrayIcon.cpp be25497<br>
src/aboutdialog/libattica-ocsclient/activitylistjob.cpp 77044cf<br>
src/aboutdialog/libattica-ocsclient/categorylistjob.cpp 427011e<br>
src/aboutdialog/libattica-ocsclient/contentjob.cpp c307e07<br>
src/aboutdialog/libattica-ocsclient/contentlistjob.cpp d371db4<br>
src/aboutdialog/libattica-ocsclient/folderlistjob.cpp dc2c137<br>
src/aboutdialog/libattica-ocsclient/knowledgebasejob.cpp f678b56<br>
src/aboutdialog/libattica-ocsclient/knowledgebaselistjob.cpp a7d6b95<br>
src/aboutdialog/libattica-ocsclient/messagelistjob.cpp 372412d<br>
src/aboutdialog/libattica-ocsclient/personjob.cpp 455178c<br>
src/aboutdialog/libattica-ocsclient/personlistjob.cpp 005542b<br>
src/aboutdialog/libattica-ocsclient/postjob.cpp cce72a3<br>
src/amarok.desktop 433c757<br>
src/browsers/filebrowser/FileBrowser.cpp 3d40d9b<br>
src/configdialog/dialogs/ScriptsConfig.cpp bbec667<br>
src/context/engines/songkick/SongkickEngine.cpp 2291719<br>
src/core-impl/collections/db/sql/SqlCollectionLocation.cpp fe6bafd<br>
src/core/podcasts/PodcastReader.cpp 409fc62<br>
src/core/support/Components.cpp 9f97eb6<br>
src/main.cpp 385e047<br>
src/org.kde.amarok.desktop PRE-CREATION<br>
src/scanner/AbstractDirectoryWatcher.cpp 168c68a<br>
src/scanner/GenericScanManager.cpp 75a22cc<br>
src/scanner/GenericScannerJob.cpp a4558fd<br>
src/scripting/scriptmanager/ScriptManager.cpp bb62be1<br>
src/services/ServiceAlbumCoverDownloader.cpp d499f62<br>
src/services/lastfm/biases/WeeklyTopBias.cpp a12f9f7<br>
src/services/magnatune/MagnatuneAlbumDownloader.cpp 5fc6584<br>
src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 0c5913a<br>
src/services/opmldirectory/OpmlDirectoryInfoParser.cpp f6ac752<br>
<br>
Diff: <a href="https://git.reviewboard.kde.org/r/125126/diff/" rel="noreferrer" target="_blank">https://git.reviewboard.kde.org/r/125126/diff/</a><br>
<br>
<br>
Testing<br>
-------<br>
<br>
It compiles 100%, and there is a segmentation fault after the end of the App::continueInit().<br>
<br>
I'm not able to trace it further.<br>
<br>
<br>
Thanks,<br>
<br>
Olivier Churlaud<br>
<br></blockquote><div>thanks,<br></div><div>rishabh <br></div></div></div></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Amarok-devel mailing list</span><br><span><a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a></span><br><span><a href="https://mail.kde.org/mailman/listinfo/amarok-devel">https://mail.kde.org/mailman/listinfo/amarok-devel</a></span><br></div></blockquote></div></body></html>