Review Request 126005: Beginned to port tests

Olivier Churlaud olivier at churlaud.com
Mon Nov 9 12:08:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126005/
-----------------------------------------------------------

Review request for Amarok.


Repository: amarok


Description
-------

I port some of the tests.. I would like your feedback on all this.


Diffs
-----

  src/amarokurls/AmarokUrl.cpp e64a1ed 
  src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp 441bac4 
  src/core-impl/meta/timecode/TimecodeTrackProvider.cpp 2c6fd52 
  src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp 6691a20 
  src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 8330c3d 
  src/core/support/Amarok.cpp 1d83542 
  tests/core/collections/support/TestTrackForUrlWorker.cpp 7d9bebf 
  tests/core/meta/TestMetaTrack.h 0859988 
  tests/core/meta/TestMetaTrack.cpp 0f5ee16 
  tests/dynamic/TestDynamicModel.cpp 43664f5 
  tests/timecode/TestTimecodeTrackProvider.cpp 82f66bb 

Diff: https://git.reviewboard.kde.org/r/126005/diff/


Testing
-------

compiled and path some tests:

16 - testtrackforurlworker (Failed)
18 - testmetatrack (Failed)
26 - testsqldatabaseupdater (Failed)
27 - testsqlalbum (Failed)
28 - testsqlartist (Failed)
29 - testsqlcollection (Failed)
30 - testsqlquerymaker (Failed)
31 - testsqlscanmanager (Failed)
32 - testsqltrack (Failed)
33 - testsqlcollectionlocation (Failed)
37 - testcuefilesupport (Failed)
38 - testmetafiletrack (Failed)
40 - testasxplaylist (Failed)
41 - testm3uplaylist (Failed)
42 - testplsplaylist (Failed)
43 - testxspfplaylist (Failed)
45 - testtrackloader (Failed)
46 - testdynamicmodel (Failed)  << Corrected but memory leak now.
49 - testplaylistfileprovider (Failed)


Thanks,

Olivier Churlaud

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20151109/2d5cf2f8/attachment.html>


More information about the Amarok-devel mailing list