<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126005/">https://git.reviewboard.kde.org/r/126005/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Olivier Churlaud.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I port some of the tests.. I would like your feedback on all this.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiled and path some tests:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">16 - testtrackforurlworker (Failed)
18 - testmetatrack (Failed)
26 - testsqldatabaseupdater (Failed)
27 - testsqlalbum (Failed)
28 - testsqlartist (Failed)
29 - testsqlcollection (Failed)
30 - testsqlquerymaker (Failed)
31 - testsqlscanmanager (Failed)
32 - testsqltrack (Failed)
33 - testsqlcollectionlocation (Failed)
37 - testcuefilesupport (Failed)
38 - testmetafiletrack (Failed)
40 - testasxplaylist (Failed)
41 - testm3uplaylist (Failed)
42 - testplsplaylist (Failed)
43 - testxspfplaylist (Failed)
45 - testtrackloader (Failed)
46 - testdynamicmodel (Failed)  << Corrected but memory leak now.
49 - testplaylistfileprovider (Failed)</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/amarokurls/AmarokUrl.cpp <span style="color: grey">(e64a1ed)</span></li>

 <li>src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp <span style="color: grey">(441bac4)</span></li>

 <li>src/core-impl/meta/timecode/TimecodeTrackProvider.cpp <span style="color: grey">(2c6fd52)</span></li>

 <li>src/core-impl/playlists/types/file/asx/ASXPlaylist.cpp <span style="color: grey">(6691a20)</span></li>

 <li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(8330c3d)</span></li>

 <li>src/core/support/Amarok.cpp <span style="color: grey">(1d83542)</span></li>

 <li>tests/core/collections/support/TestTrackForUrlWorker.cpp <span style="color: grey">(7d9bebf)</span></li>

 <li>tests/core/meta/TestMetaTrack.h <span style="color: grey">(0859988)</span></li>

 <li>tests/core/meta/TestMetaTrack.cpp <span style="color: grey">(0f5ee16)</span></li>

 <li>tests/dynamic/TestDynamicModel.cpp <span style="color: grey">(43664f5)</span></li>

 <li>tests/timecode/TestTimecodeTrackProvider.cpp <span style="color: grey">(82f66bb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126005/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>