Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist
Robert Marshall
robert at capuchin.co.uk
Wed Jul 23 15:44:21 UTC 2014
Matěj
Are those instructions to me? Do I just need to click the 'ship it' on
the reviewboard (as you can tell I've not done this before!). I don't
have (AFAIK) permission to submit to the git repository - or does the
review board handle this?
Robert
Matěj Laitl writes:
> This is an automatically generated e-mail. To reply, visit: https://
> git.reviewboard.kde.org/r/119429/
>
>
> On July 23rd, 2014, 5:12 p.m. CEST, Matěj Laitl wrote:
>
> Looks good to me, ship it and thanks. :)
>
>
>
> Please don't forget to add relevant tags to commit:
>
>
>
>
> REVIEW: ...
>
> BUG: ...
>
> FIXED-IN: ...
>
>
>
> - Matěj
>
>
> On July 23rd, 2014, 5:07 p.m. CEST, Robert Marshall wrote:
>
> Review request for Amarok.
> By Robert Marshall.
>
> Updated July 23, 2014, 5:07 p.m.
>
> Bugs: 337725
> Repository: amarok
>
> Description
>
> [Bug 337725] Text for RandomBiasFactory says 'random tracks' but the text once added is 'random songs'
>
>
>
> Testing
>
> Built (kubuntu 14.04)
>
> Checked that existing dynamic mode playlists with 'random songs' displays the new text
>
> Checked that random track addition to a playlist displays correctly.
>
> Checked that on running the playlist it looks like random tracks are being added
>
>
>
> Diffs
>
> • src/dynamic/Bias.cpp (d0aab75)
> • src/dynamic/biases/SearchQueryBias.cpp (cfe4b01)
>
> View Diff
>
More information about the Amarok-devel
mailing list