Review Request 108964: Added 3 different seek options (with customizable seek lengths)

Darth Codus darthcodus at gmail.com
Wed Feb 20 05:08:13 UTC 2013


Thanks :)
I'll get to the documentation in a short while.
But aren't conflicting default shortcuts bad user experience?
On Feb 20, 2013 3:21 AM, "Matěj Laitl" <matej at laitl.cz> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108964/
>
> Ship it!
>
> Looks good to me, will merge in a few moments. Anmol, please document the new shortcuts on http://userbase.kde.org/Amarok/Manual/References/KeybindingReference/AmarokShortcuts and the new hidden config options on relevant page under http://community.kde.org/Amarok/Development#Configuration_files  Perhaps add link from AmarokShortcuts to appropriate section of the amarokrc page.
>
>
> - Matěj
>
> On February 19th, 2013, 3:37 p.m. UTC, Anmol Ahuja wrote:
>   Review request for Amarok.
> By Anmol Ahuja.
>
> *Updated Feb. 19, 2013, 3:37 p.m.*
> Description
>
> Added 3 different seek options with customizable seek durations which can be set in the playback-config:
> Control + L/R - Short seek
>           L/R - Normal/ Medium seek
> Shift   + L/R - Long seek
>
>   Diffs
>
>    - src/amarokconfig.kcfg (3ebf71d)
>    - src/MainWindow.cpp (8f985dc)
>    - src/MainWindow.h (27725b3)
>
> View Diff <http://git.reviewboard.kde.org/r/108964/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130220/749649df/attachment.html>


More information about the Amarok-devel mailing list