Review Request 108964: Added 3 different seek options (with customizable seek lengths)

Matěj Laitl matej at laitl.cz
Wed Feb 20 16:51:45 UTC 2013


On 20. 2. 2013 Darth Codus wrote:
> On Feb 20, 2013 3:21 AM, "Matěj Laitl" <matej at laitl.cz> wrote:
> >    This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/108964/
> > 
> > Ship it!
> > 
> > Looks good to me, will merge in a few moments. Anmol, please document the
> 
> Thanks :)
> I'll get to the documentation in a short while.
> But aren't conflicting default shortcuts bad user experience?

They are, I will fix this before committing (which is the source of delays).

P.S.: when commenting on a review request, it it best to use the web interface 
so that people reading it on the web page don't loose context.

P.P.S.: What is your real name? I guess Anmol Ahuja? Using real name is 
preferred in git author and commiter field, e-mails, identity.kde.org and 
bugzilla accounts, please adjust that accordingly. (we still use nicknames on 
IRC)

	Matěj


More information about the Amarok-devel mailing list