Review Request 108964: Added 3 different seek options (with customizable seek lengths)
Matěj Laitl
matej at laitl.cz
Tue Feb 19 21:51:08 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108964/#review27752
-----------------------------------------------------------
Ship it!
Looks good to me, will merge in a few moments. Anmol, please document the new shortcuts on http://userbase.kde.org/Amarok/Manual/References/KeybindingReference/AmarokShortcuts and the new hidden config options on relevant page under http://community.kde.org/Amarok/Development#Configuration_files Perhaps add link from AmarokShortcuts to appropriate section of the amarokrc page.
- Matěj Laitl
On Feb. 19, 2013, 3:37 p.m., Anmol Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108964/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2013, 3:37 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Added 3 different seek options with customizable seek durations which can be set in the playback-config:
> Control + L/R - Short seek
> L/R - Normal/ Medium seek
> Shift + L/R - Long seek
>
>
> Diffs
> -----
>
> src/amarokconfig.kcfg 3ebf71d
> src/MainWindow.cpp 8f985dc
> src/MainWindow.h 27725b3
>
> Diff: http://git.reviewboard.kde.org/r/108964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anmol Ahuja
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130219/4d9ffe5f/attachment.html>
More information about the Amarok-devel
mailing list