Review Request 108964: Added 3 different seek options (with customizable seek lengths)
Anmol Ahuja
darthcodus at gmail.com
Tue Feb 19 15:37:54 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108964/
-----------------------------------------------------------
(Updated Feb. 19, 2013, 3:37 p.m.)
Review request for Amarok.
Changes
-------
1. Got rid of the config for the micro-options
2. Moved all slots to MainWindow.cpp
3. Set the default seek time for the short seek to 2 seconds
4. Made the seek action labels actually read the seek times from the config, formatted with KLocale::prettyFormatDuration
5. Removed spaces around the arguments in the SLOT macro calls
The Control+Left shortcut, however, conflicts with the previous browser shortcut.
Description
-------
Added 3 different seek options with customizable seek durations which can be set in the playback-config:
Control + L/R - Short seek
L/R - Normal/ Medium seek
Shift + L/R - Long seek
Diffs (updated)
-----
src/amarokconfig.kcfg 3ebf71d
src/MainWindow.cpp 8f985dc
src/MainWindow.h 27725b3
Diff: http://git.reviewboard.kde.org/r/108964/diff/
Testing
-------
Thanks,
Anmol Ahuja
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130219/d5288924/attachment.html>
More information about the Amarok-devel
mailing list