Review Request 114282: Make the scripts translatable through KDE translation system

[Yuri Chornoivan]

> On Dec. 3, 2013, 7:42 p.m., Matěj Laitl wrote:
> > This looks worth the complication to me. The renaming on install might be confusing to some, but it is far less worse than shipping untranslated strings. I just propose adding short note into the CMakeCache.txt files mentioning why we do the renaming (so that we don't forget in the future).
> > 
> > I can imagine a clearer solution: telling scripty (in Messages.sh?) to treat .spec files in Amarok the same way treats .desktop files. Can you guess much effort would that take, Yuri?

Spec files are used for RPM packaging. There are many usual spec files in KDE source code repos (KSirk, KLook, Krusader...). Do not know if it is worth to teach scripty to determine the type of such spec files. For me, it is not worth to do so.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114282/#review45051
-----------------------------------------------------------


On Dec. 3, 2013, 6:55 p.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114282/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 6:55 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 305264
>     https://bugs.kde.org/show_bug.cgi?id=305264
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Scripty can effectively help to translate .desktop files, so this patch tries to trick scripty. The target translated files still installed as .spec by renaming during installation.
> 
> 
> Diffs
> -----
> 
>   src/scripts/librivox_service/CMakeLists.txt f4ef2da 
>   src/scripts/librivox_service/script.desktop PRE-CREATION 
>   src/scripts/librivox_service/script.spec 26719d5 
>   src/scripts/lyrics_lyricwiki/CMakeLists.txt aa25589 
>   src/scripts/lyrics_lyricwiki/script.desktop PRE-CREATION 
>   src/scripts/lyrics_lyricwiki/script.spec d3346dc 
>   src/scripts/radio_station_service/CMakeLists.txt d053697 
>   src/scripts/radio_station_service/script.desktop PRE-CREATION 
>   src/scripts/radio_station_service/script.spec 9e7fb0e 
>   src/scripts/script_console/CMakeLists.txt 4d31f7c 
>   src/scripts/script_console/script.desktop PRE-CREATION 
>   src/scripts/script_console/script.spec 7d0a59d 
> 
> Diff: http://git.reviewboard.kde.org/r/114282/diff/
> 
> 
> Testing
> -------
> 
> Compiles, installs, can be translated through KDE translation system.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131206/3d780d4e/attachment.html>