<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114282/">http://git.reviewboard.kde.org/r/114282/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2013, 7:42 p.m. UTC, <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks worth the complication to me. The renaming on install might be confusing to some, but it is far less worse than shipping untranslated strings. I just propose adding short note into the CMakeCache.txt files mentioning why we do the renaming (so that we don't forget in the future).
I can imagine a clearer solution: telling scripty (in Messages.sh?) to treat .spec files in Amarok the same way treats .desktop files. Can you guess much effort would that take, Yuri?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Spec files are used for RPM packaging. There are many usual spec files in KDE source code repos (KSirk, KLook, Krusader...). Do not know if it is worth to teach scripty to determine the type of such spec files. For me, it is not worth to do so.</pre>
<br />
<p>- Yuri</p>
<br />
<p>On December 3rd, 2013, 6:55 p.m. UTC, Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2013, 6:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=305264">305264</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Scripty can effectively help to translate .desktop files, so this patch tries to trick scripty. The target translated files still installed as .spec by renaming during installation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, installs, can be translated through KDE translation system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scripts/librivox_service/CMakeLists.txt <span style="color: grey">(f4ef2da)</span></li>
<li>src/scripts/librivox_service/script.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripts/librivox_service/script.spec <span style="color: grey">(26719d5)</span></li>
<li>src/scripts/lyrics_lyricwiki/CMakeLists.txt <span style="color: grey">(aa25589)</span></li>
<li>src/scripts/lyrics_lyricwiki/script.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripts/lyrics_lyricwiki/script.spec <span style="color: grey">(d3346dc)</span></li>
<li>src/scripts/radio_station_service/CMakeLists.txt <span style="color: grey">(d053697)</span></li>
<li>src/scripts/radio_station_service/script.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripts/radio_station_service/script.spec <span style="color: grey">(9e7fb0e)</span></li>
<li>src/scripts/script_console/CMakeLists.txt <span style="color: grey">(4d31f7c)</span></li>
<li>src/scripts/script_console/script.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scripts/script_console/script.spec <span style="color: grey">(7d0a59d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114282/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>