Review Request 114282: Make the scripts translatable through KDE translation system

Yuri Chornoivan yurchor at ukr.net
Fri Dec 6 06:02:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114282/
-----------------------------------------------------------

(Updated Dec. 6, 2013, 6:02 a.m.)


Review request for Amarok.


Changes
-------

Add a description to each CMakeLists.txt files.


Bugs: 305264
    https://bugs.kde.org/show_bug.cgi?id=305264


Repository: amarok


Description
-------

Scripty can effectively help to translate .desktop files, so this patch tries to trick scripty. The target translated files still installed as .spec by renaming during installation.


Diffs (updated)
-----

  src/scripts/librivox_service/CMakeLists.txt f4ef2da 
  src/scripts/librivox_service/script.desktop PRE-CREATION 
  src/scripts/librivox_service/script.spec 26719d5 
  src/scripts/lyrics_lyricwiki/CMakeLists.txt aa25589 
  src/scripts/lyrics_lyricwiki/script.desktop PRE-CREATION 
  src/scripts/lyrics_lyricwiki/script.spec d3346dc 
  src/scripts/radio_station_service/CMakeLists.txt d053697 
  src/scripts/radio_station_service/script.desktop PRE-CREATION 
  src/scripts/radio_station_service/script.spec 9e7fb0e 
  src/scripts/script_console/CMakeLists.txt 4d31f7c 
  src/scripts/script_console/script.desktop PRE-CREATION 
  src/scripts/script_console/script.spec 7d0a59d 

Diff: http://git.reviewboard.kde.org/r/114282/diff/


Testing
-------

Compiles, installs, can be translated through KDE translation system.


Thanks,

Yuri Chornoivan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20131206/2251eda0/attachment.html>


More information about the Amarok-devel mailing list