Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112221/#review38517
-----------------------------------------------------------


This review has been submitted with commit 61350cc9e95ba228f7ec78625c38411cfb636ce3 by Mark Kretschmann on behalf of Frank Meerkoetter to branch master.

- Commit Hook


On Aug. 23, 2013, 6:57 a.m., Frank Meerkoetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112221/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 6:57 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix the few remaining cases i missed on the first run. See: https://git.reviewboard.kde.org/r/112148/
> 
> 
> This addresses bug 313504.
>     https://bugs.kde.org/show_bug.cgi?id=313504
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 
>   src/dialogs/DiagnosticDialog.cpp a5f2e17 
>   tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 
> 
> Diff: http://git.reviewboard.kde.org/r/112221/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass.
> 
> 
> Thanks,
> 
> Frank Meerkoetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/b720af53/attachment.html>