Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

Frank Meerkoetter frank at meerkoetter.org
Fri Aug 23 06:57:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112221/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Fix the few remaining cases i missed on the first run. See: https://git.reviewboard.kde.org/r/112148/


This addresses bug 313504.
    https://bugs.kde.org/show_bug.cgi?id=313504


Diffs
-----

  src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 
  src/dialogs/DiagnosticDialog.cpp a5f2e17 
  tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 

Diff: http://git.reviewboard.kde.org/r/112221/diff/


Testing
-------

unit tests pass.


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130823/6bc95f04/attachment-0001.html>


More information about the Amarok-devel mailing list