Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

Mark Kretschmann kretschmann at kde.org
Sun Aug 25 08:45:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112221/
-----------------------------------------------------------

(Updated Aug. 25, 2013, 8:45 a.m.)


Status
------

This change has been marked as submitted.


Review request for Amarok.


Description
-------

Fix the few remaining cases i missed on the first run. See: https://git.reviewboard.kde.org/r/112148/


This addresses bug 313504.
    https://bugs.kde.org/show_bug.cgi?id=313504


Diffs
-----

  src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 
  src/dialogs/DiagnosticDialog.cpp a5f2e17 
  tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 

Diff: http://git.reviewboard.kde.org/r/112221/diff/


Testing
-------

unit tests pass.


Thanks,

Frank Meerkoetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20130825/2e19d933/attachment.html>


More information about the Amarok-devel mailing list